Device.id change & wifi config

Greg_Oleksiak · May 1, 2019, 12:41pm

My goal is: To create a method of provisioning an ESP32 device in as close to automated fashion as possible. I am currently using a bash script for this approach. I want to set a custom device.id before registering the device on GCloud.
My actions are: 1) Run: mos config-set device.id=8C28AB79-4115-48D8-A6E1-82D7BFE7BCF2 2) Run: mos wifi MY_SSID MY_PASS 3) …GCloud config
The result I see is: https://gist.github.com/goleksiak/01f685aadfbb9429a631493b4ccd6552
My expectation & question is: If I run either of the 2 commands above individually, they work fine. It is only when both commands are run (in either order) do I get the same error. I assume the error on Line 37 is the problem but I don’t know why.

nliviu · May 1, 2019, 2:07pm

The error comes from here
wifi_sta_set_host_name fails because the device.id which is used as hostname in the absence of wifi.sta.dhcp_hostname has a length>32.

Refs:

github.com

mongoose-os-libs/wifi/blob/2a814e9c3506e55ee7a4ac185fc64ac037597d15/src/esp32/esp32_wifi.c#L262-L271


static esp_err_t wifi_sta_set_host_name(
    const struct mgos_config_wifi_sta *cfg) {
  esp_err_t r = ESP_OK;
  const char *host_name =
      cfg->dhcp_hostname ? cfg->dhcp_hostname : mgos_sys_config_get_device_id();
  if (host_name != NULL) {
    r = tcpip_adapter_set_hostname(TCPIP_ADAPTER_IF_STA, host_name);
  }
  return r;
}

github.com

cesanta/esp-idf/blob/c2d1c89b5296ecbdf62f8143269164c14d1fef35/components/tcpip_adapter/tcpip_adapter_lwip.c#L1147-L1174


esp_err_t tcpip_adapter_set_hostname(tcpip_adapter_if_t tcpip_if, const char *hostname)
{
#if LWIP_NETIF_HOSTNAME
    TCPIP_ADAPTER_IPC_CALL(tcpip_if, 0, 0, hostname, tcpip_adapter_set_hostname_api);
    struct netif *p_netif;
    static char hostinfo[TCPIP_ADAPTER_IF_MAX][TCPIP_HOSTNAME_MAX_SIZE + 1];


    if (tcpip_if >= TCPIP_ADAPTER_IF_MAX || hostname == NULL) {
        return ESP_ERR_TCPIP_ADAPTER_INVALID_PARAMS;
    }


    if (strlen(hostname) > TCPIP_HOSTNAME_MAX_SIZE) {
        return ESP_ERR_TCPIP_ADAPTER_INVALID_PARAMS;
    }


    p_netif = esp_netif[tcpip_if];
    if (p_netif != NULL) {
        memset(hostinfo[tcpip_if], 0, sizeof(hostinfo[tcpip_if]));
        strlcpy(hostinfo[tcpip_if], hostname, sizeof(hostinfo[tcpip_if]));
        p_netif->hostname = hostinfo[tcpip_if];

This file has been truncated. show original

github.com

cesanta/esp-idf/blob/c2d1c89b5296ecbdf62f8143269164c14d1fef35/components/tcpip_adapter/include/tcpip_adapter.h#L584


*
* @param[in]   wifi_sta_list_t *wifi_sta_list: station list info
* @param[out]  tcpip_adapter_sta_list_t *tcpip_sta_list: station list info
*
* @return ESP_OK
*         ESP_ERR_TCPIP_ADAPTER_NO_MEM
*         ESP_ERR_TCPIP_ADAPTER_INVALID_PARAMS
*/
esp_err_t tcpip_adapter_get_sta_list(wifi_sta_list_t *wifi_sta_list, tcpip_adapter_sta_list_t *tcpip_sta_list);


#define TCPIP_HOSTNAME_MAX_SIZE    32
/**
* @brief  Set the hostname to the interface
*
* @param[in]   tcpip_if: the interface which we will set the hostname
* @param[in]   hostname: the host name for set the interface, the max length of hostname is 32 bytes
*
* @return ESP_OK:success
*         ESP_ERR_TCPIP_ADAPTER_IF_NOT_READY:interface status error
*         ESP_ERR_TCPIP_ADAPTER_INVALID_PARAMS:parameter error
*/

Greg_Oleksiak · May 1, 2019, 3:47pm

Many thanks @nliviu!! I ended up stripping the ‘-’ chars out of my UUID with: dhcpHostname=$(echo "$deviceId" | sed -e 's/-//g') and setting that as the wifi.sta.dhcp_hostname & it worked!

Greg_Oleksiak · May 1, 2019, 4:10pm

Well, it looks like running mos license resets the device.id so I’m thinking about just giving up on setting a custom id.

Greg_Oleksiak · May 1, 2019, 4:27pm

Setting gcp.device to a custom uuid gets overwritten during mos gcp-iot-setup too - oh well.